Fix .head causing JsonSupport sink to terminate #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
force-pushed
the
fix-head-causing-sink-to-terminate
branch
from
5d76584
to
1d151de
Compare
Pull Request Test Coverage Report for Build 10828056638Details
💛 - Coveralls |
Ah, interesting, that also explains the difference of behavior with Pekko :) Thanks for the quick fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #15
This seems to have been an honest mistake when copying the original code from the project at https://github.com/knutwalker/akka-stream-json/blob/master/http-json/src/main/scala/de/knutwalker/akka/http/JsonSupport.scala
I must have done some "optimization" or "improvement" while causing a regression that slipped through current test coverage.